-
Notifications
You must be signed in to change notification settings - Fork 310
New SVG, Icons, PNGs and X PixMaps #879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New SVG, Icons, PNGs and X PixMaps #879
Conversation
This PR clean up the old SVG, Icons, PNGs and X PixMaps by providing optimized much smaller file size versions while at the same time keeping resolutions untouched. Shadows are removed from the files.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Why do you think this change is necessary? Also, the size of the logo has been increased. Could you please mention this in the PR description as well, along with a justification for the change? |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
Not being a designer, these claims seem like a matter of taste to me. It would be helpful to hear other designers' opinions.
I have deep respect for @jonasschnelli, but PR discussions should not be based on someone's personal opinion without supporting reasoning.
That sounds at least controversial. If that were true, the current logos wouldn’t have been merged in the first place. |
I briefly discussed the issue of copyright and authorship on the SVG with the PR author in #bitcoin (IRC). It sounded to me that the PR author was worried about the copyright and MIT licensing as well as who was the original designer. Unclear what the intention of this PR is as this also changes the copyright in the file. I have no opinion on visual style. |
This comment was marked as abuse.
This comment was marked as abuse.
Please update the PR description accordingly.
That’s not a justification for the changes, neither from a technical perspective nor a design one. NACK from me. |
@1BitcoinBoWP1FZ4xwTNkq6XksKidmgYYw that kind of commentary is unacceptable. |
This PR clean up the old SVG, Icons, PNGs and X PixMaps by providing optimized much smaller file size versions while at the same time keeping resolutions untouched. Shadows are removed from the files.